feat(proxy-cache): the cache_zone field in the schema should be optional #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
reviewed
Nov 17, 2020
moonming
reviewed
Nov 17, 2020
doc/zh-cn/plugins/proxy-cache.md
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| | 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 | | |||
| | ------------------ | -------------- | ------ | ------------------------- | ------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------- | | |||
| | cache_zone | string | 必须 | | | 指定使用哪个缓存区域，不同的缓存区域可以配置不同的路径，在conf/config.yaml文件中可以预定义使用的缓存区域 | | |||
| | cache_zone | string | 可选 | disk_cache_one | | 指定使用哪个缓存区域，不同的缓存区域可以配置不同的路径，在conf/config.yaml文件中可以预定义使用的缓存区域 | | |||
There was a problem hiding this comment.
Need more details about how to use this config
There was a problem hiding this comment.
I will update later.
gxthrj
approved these changes
Nov 17, 2020
doc/plugins/proxy-cache.md
Outdated
| @@ -31,7 +31,7 @@ The proxy-cache plugin, which provides the ability to cache upstream response da | |||
|
|
|||
| | Name | Type | Requirement | Default | Valid | Description | | |||
| | ------------------ | -------------- | ----------- | ------------------------- | ------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | cache_zone | string | required | | | Specify which cache area to use, each cache area can be configured with different paths. In addition, cache areas can be predefined in conf/config.yaml file | | |||
| | cache_zone | string | optional | disk_cache_one | | Specify which cache area to use, each cache area can be configured with different paths. In addition, cache areas can be predefined in conf/config.yaml file | | |||
There was a problem hiding this comment.
We need to tell people the cache will be invalid if cache_zone do not match.
There was a problem hiding this comment.
Nice, this sounds great.
membphis
approved these changes
Nov 18, 2020
moonming
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2767
What this PR does / why we need it:
Pre-submission checklist: