feat: allow customizing lua_package_path & lua_package_cpath #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <[email protected]>
dabue
approved these changes
Jan 26, 2021
Firstsawyou
reviewed
Jan 26, 2021
.travis/apisix_cli_test/test_main.sh
Outdated
| make stop | ||
|
|
||
| if grep "failed to load plugin [3rd-party]" logs/error.log > /dev/null; then | ||
| echo "failed: 3rd party plugin can not be loaded" |
There was a problem hiding this comment.
I think it’s better to use 3rd-party to keep the plugin name consistent,
.travis/apisix_cli_test/test_main.sh
Outdated
| echo "failed: 3rd party plugin can not be loaded" | ||
| exit 1 | ||
| fi | ||
| echo "passed: 3rd party plugin can be loaded" |
Signed-off-by: spacewander <[email protected]>
tokers
reviewed
Jan 26, 2021
doc/plugin-develop.md
Outdated
| @@ -29,10 +30,39 @@ | |||
| - [**register public API**](#register-public-api) | |||
| - [**register control API**](#register-control-api) | |||
|
|
|||
| ## where to put your plugin | |||
| if conf then | ||
| local path = conf | ||
| if path:byte(-1) ~= str_byte(';') then | ||
| path = path .. ';' |
There was a problem hiding this comment.
if conf is "", it'll return ";", is this OK for the lua_package_path directive?
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
membphis
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: