Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow route to inherit hosts from service #4977

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: spacewander <[email protected]>
@spacewander spacewander merged commit 0ba89d5 into apache:master Sep 6, 2021
@spacewander spacewander deleted the shh branch September 6, 2021 00:57
@Donghui0
Copy link
Contributor

in plugin.merge_service_route function, need to add processing for route.value.timeout. Otherwise, the timeout attribute of ApisixRoute will be invalid.

I have a question in the merge service_route method. Why not directly core.table.deepcopy(route_conf), assign the attribute of service to new_conf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants