Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: etcd cluster single node failure APISIX startup failure #5158

Merged
merged 16 commits into from
Oct 14, 2021
Merged

feat: etcd cluster single node failure APISIX startup failure #5158

merged 16 commits into from
Oct 14, 2021

Conversation

shuaijinchao
Copy link
Member

What this PR does / why we need it:

FIX #5115

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@shuaijinchao
Copy link
Member Author

This PR requires lua-resty-etcd to support round robin check when health check is not enabled.

@spacewander spacewander changed the title bugfix: etcd cluster single node failure APISIX startup failure feat: etcd cluster single node failure APISIX startup failure Sep 29, 2021
okaybase
okaybase approved these changes Oct 2, 2021
View reviewed changes
t/cli/test_etcd_ha.sh Outdated Show resolved Hide resolved
t/cli/test_etcd_ha.sh Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Oct 2, 2021
View reviewed changes
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
@shuaijinchao shuaijinchao mentioned this pull request Oct 4, 2021
Merged
tokers
tokers reviewed Oct 13, 2021
View reviewed changes
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Oct 13, 2021
View reviewed changes
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
apisix/cli/etcd.lua Show resolved Hide resolved
t/cli/test_etcd_ha.sh Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Oct 14, 2021
View reviewed changes
apisix/cli/etcd.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit a413014 into apache:master Oct 14, 2021
@tylitianrui tylitianrui mentioned this pull request Feb 15, 2022
Merged
4 tasks
tzssangglass pushed a commit to tzssangglass/apisix that referenced this pull request Feb 21, 2022
@shuaijinchao @tzssangglass
feat: etcd cluster single node failure APISIX startup failure (apache…
d916fac 
…#5158)

(cherry picked from commit a413014)
@tzssangglass tzssangglass mentioned this pull request Feb 22, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@okaybase okaybase okaybase approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: APISIX start failed when one of ETCD nodes down
4 participants
@shuaijinchao @spacewander @tokers @okaybase