feat(loggly): support http/s bulk sending for batch logs #6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample: for batch size 3 |
spacewander
reviewed
Jan 27, 2022
apisix/plugins/loggly.lua
Outdated
| @@ -232,13 +233,71 @@ local function send_data_over_udp(message) | |||
| end | |||
|
|
|||
|
|
|||
| local function send_bulk_over_http(message, metadata, conf) | |||
| local endpoint = path.join(metadata.value.host, "bulk", conf.customer_token, "tag", "bulk") | |||
| local has_prefix = metadata.value.host:find("http") | |||
There was a problem hiding this comment.
Better to use
Line 46 in 615ee41
There was a problem hiding this comment.
Nice. Thanks for the suggestion.
Updated.
spacewander
approved these changes
Jan 27, 2022
tokers
reviewed
Jan 27, 2022
apisix/plugins/loggly.lua
Outdated
| if not body then | ||
| return false, "failed to send log to loggly, http status code: " .. res.status | ||
| else | ||
| return false, "failed to send log to loggly, " .. res.body |
There was a problem hiding this comment.
Should we also print the status code here?
There was a problem hiding this comment.
Yep. Sounds good to me. Thanks!
tokers
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#6112 [Phase -2 Part 1]
Pre-submission checklist: