Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traffic-split): failed to match rule when the first rule failed #6292

Merged
merged 4 commits into from
Feb 14, 2022
Merged

fix(traffic-split): failed to match rule when the first rule failed #6292

merged 4 commits into from
Feb 14, 2022

Conversation

tangzhenhuang
Copy link
Contributor

@tangzhenhuang tangzhenhuang commented Feb 11, 2022 •
edited
Loading

What this PR does / why we need it:

fix #6288

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

starsz
starsz reviewed Feb 12, 2022
View reviewed changes
t/plugin/traffic-split5.t Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 605141c into apache:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starsz starsz starsz approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: traffic-split plugin do not match if the first matcher failed
3 participants
@tangzhenhuang @spacewander @starsz