Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(real-ip): support search recursive #6988

Merged
merged 19 commits into from
May 13, 2022

Conversation

tangzhenhuang
Copy link
Contributor

@tangzhenhuang tangzhenhuang commented May 6, 2022

Description

Support real ip recusive, see http://nginx.org/en/docs/http/ngx_http_realip_module.html

Fixes #6602

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass changed the title Real ip recursive feat(real-ip): support search recursive May 6, 2022
docs/en/latest/plugins/real-ip.md Outdated Show resolved Hide resolved
apisix/plugins/real-ip.lua Outdated Show resolved Hide resolved
tangzhenhuang and others added 2 commits May 7, 2022 11:28
Thanks for review, it does reduce one loop.

Co-authored-by: 罗泽轩 <[email protected]>
@tzssangglass
Copy link
Member

LGTM

spacewander
spacewander previously approved these changes May 8, 2022
@spacewander spacewander added the wait for update wait for the author's response in this issue/PR label May 11, 2022
apisix/plugins/real-ip.lua Outdated Show resolved Hide resolved
apisix/plugins/real-ip.lua Show resolved Hide resolved
tzssangglass
tzssangglass previously approved these changes May 12, 2022
@spacewander spacewander merged commit 0842b69 into apache:master May 13, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
Co-authored-by: tangzhenhuang <[email protected]>
Co-authored-by: 罗泽轩 <[email protected]>
spacewander added a commit that referenced this pull request Jun 30, 2022
Co-authored-by: tangzhenhuang <[email protected]>
Co-authored-by: 罗泽轩 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait for update wait for the author's response in this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: real_ip_recursive for real-ip plugin
4 participants