Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(log-rorate): log-rotate plugin support max_size #7749

Merged
merged 11 commits into from
Aug 26, 2022
Merged

feat(log-rorate): log-rotate plugin support max_size #7749

merged 11 commits into from
Aug 26, 2022

Conversation

qihaiyan
Copy link
Contributor

@qihaiyan qihaiyan commented Aug 20, 2022 •
edited
Loading

Description

log-rotate plugin support max_size

Fixes #7724

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

spacewander
spacewander reviewed Aug 21, 2022
View reviewed changes
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
@spacewander
Copy link
Member

Let's merge master to make CI pass.

@qihaiyan
Copy link
Contributor Author

Let's merge master to make CI pass.

How to merge master?

@tzssangglass
Copy link
Member

How to merge master?

  1. pull the latest master branch from upstream to your local
  2. merge the master branch to your PR branch

@qihaiyan
Copy link
Contributor Author

Could you help to check why the chaos-test failed? @spacewander

@spacewander
Copy link
Member

Could you help to check why the chaos-test failed? @spacewander

Rerun.

spacewander
spacewander reviewed Aug 24, 2022
View reviewed changes
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
t/plugin/log-rotate3.t Outdated Show resolved Hide resolved
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Aug 25, 2022
View reviewed changes
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
apisix/plugins/log-rotate.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit db75890 into apache:master Aug 26, 2022
@qihaiyan qihaiyan deleted the feat-7724 branch August 26, 2022 06:30
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@qihaiyan @spacewander
@guitu168 @Liu-Junlin
feat(log-rorate): log-rotate plugin support max_size (apache#7749)
e75b73a 
Co-authored-by: 罗泽轩 <[email protected]>
Co-authored-by: Fei Han <[email protected]>
Co-authored-by: qihaiyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitu168 guitu168 guitu168 left review comments

@tzssangglass tzssangglass tzssangglass approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to log-rotate plugin support max_size
4 participants
@qihaiyan @spacewander @tzssangglass @guitu168