change: update the default value about enable_cpu_affinity #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzssangglass
changed the title
tzssangglass
previously approved these changes
Oct 13, 2022
tokers
previously approved these changes
Oct 13, 2022
spacewander
reviewed
Oct 14, 2022
|
Don't forget to update the commit message like #8051 (comment) in your PRs. |
Co-authored-by: 罗泽轩 <[email protected]>
Co-authored-by: 罗泽轩 <[email protected]>
Thank your suggestion, I have changed. |
Err, it should be |
spacewander
approved these changes
Oct 18, 2022
tzssangglass
approved these changes
Oct 18, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Co-authored-by: 罗泽轩 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nowadays, more and more users deploy APISIX via container. As Nginx's worker_cpu_affinity doesn't count with cgroup, enabling worker_cpu_affinity by default will affect the behavior of APISIX, for instance, multiple instances will be bound to one CPU. To avoid this problem, it would be better to disable CPU affinity option by default in the conf/config-default.yaml.
Fixes #8042
Checklist