Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hide credentials for jwt-auth plugin #8206

Merged

Conversation

pixeldin
Copy link
Contributor

@pixeldin pixeldin commented Oct 30, 2022

Description

Provides an optional feat for the jwt-auth plugin to hide authentication upstream as requested in #8122.
Setting hide_credentials to true in the plugin config will hide related auth parameters in upstream.

Fixes #8122

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@pixeldin pixeldin marked this pull request as ready for review October 30, 2022 18:23
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
tokers
tokers previously approved these changes Nov 1, 2022
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
tokers
tokers previously approved these changes Nov 8, 2022
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
docs/zh/latest/plugins/jwt-auth.md Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
@pixeldin pixeldin requested review from spacewander and tokers and removed request for tokers and spacewander November 9, 2022 03:32
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
@pixeldin pixeldin requested review from spacewander and removed request for tokers November 9, 2022 07:03
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
@pixeldin pixeldin requested review from tzssangglass and removed request for spacewander November 9, 2022 08:46
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Show resolved Hide resolved
starsz
starsz previously approved these changes Nov 11, 2022
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
t/plugin/jwt-auth3.t Outdated Show resolved Hide resolved
spacewander
spacewander previously approved these changes Nov 15, 2022
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixeldin
Could you apply this patch in your code before we can merge it?
Thanks!

diff --git t/plugin/jwt-auth3.t t/plugin/jwt-auth3.t
index c0a1961d..fd53d56a 100755
--- t/plugin/jwt-auth3.t
+++ t/plugin/jwt-auth3.t
@@ -30,10 +30,10 @@ add_block_preprocessor(sub {

     if (!defined $block->request) {
         $block->set_value("request", "GET /t");
-    }

-    if (!$block->response_body) {
-        $block->set_value("response_body eval", "qr/^$/");
+        if (!$block->response_body) {
+            $block->set_value("response_body", "passed\n");
+        }
     }
 });

@pixeldin
Copy link
Contributor Author

@pixeldin Could you apply this patch in your code before we can merge it? Thanks!

diff --git t/plugin/jwt-auth3.t t/plugin/jwt-auth3.t
index c0a1961d..fd53d56a 100755
--- t/plugin/jwt-auth3.t
+++ t/plugin/jwt-auth3.t
@@ -30,10 +30,10 @@ add_block_preprocessor(sub {

     if (!defined $block->request) {
         $block->set_value("request", "GET /t");
-    }

-    if (!$block->response_body) {
-        $block->set_value("response_body eval", "qr/^$/");
+        if (!$block->response_body) {
+            $block->set_value("response_body", "passed\n");
+        }
     }
 });

@spacewander Thanks, Done! Please review it when you have time.

@spacewander spacewander merged commit 2f4a4db into apache:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to hide credentials for jwt-auth plugin, so that we wouldn't get jwt token at upstream
5 participants