-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support hide credentials for jwt-auth plugin #8206
Merged
spacewander
merged 29 commits into
apache:master
from
pixeldin:jwt-auth-plugin-supporting-hide-credentials
Nov 16, 2022
Merged
feat: support hide credentials for jwt-auth plugin #8206
spacewander
merged 29 commits into
apache:master
from
pixeldin:jwt-auth-plugin-supporting-hide-credentials
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
reviewed
Oct 31, 2022
update description Co-authored-by: Alex Zhang <[email protected]>
update description Co-authored-by: Alex Zhang <[email protected]>
starsz
reviewed
Oct 31, 2022
tokers
previously approved these changes
Nov 1, 2022
spacewander
reviewed
Nov 1, 2022
…th-plugin-supporting-hide-credentials
spacewander
reviewed
Nov 2, 2022
…th-plugin-supporting-hide-credentials
spacewander
reviewed
Nov 6, 2022
tzssangglass
reviewed
Nov 7, 2022
…th-plugin-supporting-hide-credentials
tokers
previously approved these changes
Nov 8, 2022
spacewander
reviewed
Nov 8, 2022
pixeldin
requested review from
spacewander and
tokers
and removed request for
tokers and
spacewander
November 9, 2022 03:32
spacewander
reviewed
Nov 9, 2022
tzssangglass
reviewed
Nov 9, 2022
tzssangglass
reviewed
Nov 9, 2022
pixeldin
requested review from
tzssangglass
and removed request for
spacewander
November 9, 2022 08:46
spacewander
reviewed
Nov 10, 2022
starsz
previously approved these changes
Nov 11, 2022
spacewander
reviewed
Nov 11, 2022
spacewander
previously approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pixeldin
Could you apply this patch in your code before we can merge it?
Thanks!
diff --git t/plugin/jwt-auth3.t t/plugin/jwt-auth3.t
index c0a1961d..fd53d56a 100755
--- t/plugin/jwt-auth3.t
+++ t/plugin/jwt-auth3.t
@@ -30,10 +30,10 @@ add_block_preprocessor(sub {
if (!defined $block->request) {
$block->set_value("request", "GET /t");
- }
- if (!$block->response_body) {
- $block->set_value("response_body eval", "qr/^$/");
+ if (!$block->response_body) {
+ $block->set_value("response_body", "passed\n");
+ }
}
});
@spacewander Thanks, Done! Please review it when you have time. |
spacewander
approved these changes
Nov 16, 2022
starsz
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides an optional feat for the jwt-auth plugin to hide authentication upstream as requested in #8122.
Setting hide_credentials to true in the plugin config will hide related auth parameters in upstream.
Fixes #8122
Checklist