-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add consul discovery module #8380
feat: add consul discovery module #8380
Conversation
Please make the CI pass, thanks! |
ok, i fixed it |
Could you start the other pipeline? |
Done |
pls fix doc lint |
done |
@spacewander @tzssangglass I had finished, and I had fixed all the CI error |
@spacewander @tzssangglass Updated, please check again, thanks |
@spacewander @tzssangglass the CI with the t/xds-library/config_xds_2.t TEST 7 is not stable, I did not modified anything about that |
@spacewander @tzssangglass May you RETURN CI to rerun the CI again, thanks |
@Fabriceli |
DONE, I had merge upstream master to dev branch. |
|
@spacewander @tzssangglass I have merged upstream master, could you re-start the CI? Thanks |
Some error in Chaos Test, May you give some hint about that? cc @spacewander @tzssangglass Failure [0.077 seconds]
Test APISIX Delay When Add ETCD Delay
/home/runner/work/apisix/apisix/t/chaos/delayetcd/delayetcd.go:100
get default apisix delay [It]
/home/runner/work/apisix/apisix/t/chaos/delayetcd/delayetcd.go:133
Expected
<time.Duration>: 15246514
to be <
<time.Duration>: 15000000
/home/runner/work/apisix/apisix/t/chaos/delayetcd/delayetcd.go:136 Error Stack: https://github.com/apache/apisix/actions/runs/3617352817/jobs/6100135416 |
rerun it |
Please take a look at this CR, thanks, cc @spacewander |
Description
As I mentioned previously in #8371 , my team submit our
consul
discovery moduleChecklist