-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: etcd data sync exception #8493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the key is deleted, the item will be set to false.
@@ -96,6 +96,10 @@ end | |||
|
|||
-- fire all clean handlers added by add_clean_handler. | |||
function _M.fire_all_clean_handlers(item) | |||
-- When the key is deleted, the item will be set to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the key is deleted, the item will be set to false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test case to avoid regression? For example, we can add a test in https://github.com/apache/apisix/blob/master/t/node/healthcheck-stop-checker.t
yes,i hava add some test cases |
@@ -103,6 +108,9 @@ __DATA__ | |||
local item, idx1, idx2 = setup() | |||
util.cancel_clean_handler(item, idx1) | |||
util.fire_all_clean_handlers(item) | |||
|
|||
local item = setup_to_false() | |||
util.fire_all_clean_handlers(item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to test this bug by deleting a key as you described in the issue? It would be great if we could cover it via an integration test which is more readable.
Hi, I had the same problem, and Is there any way to solve this problem? |
@zhangliweixyz |
we had the same problem, it occur especially in etcd_auto_compaction_mode=revision during we do a lot of update/delete operation to apisixroute |
How about this bug now? |
Since people keep asking about it, we can merge it first. |
maybe related: #8648 (comment) |
Description
Fixes #8492
Fix #8648
Checklist