fix: unnecessary YAML Config reloads #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boekkooi-lengoo
changed the title
boekkooi-lengoo
changed the title
|
Test cases is needed, you could follow this: https://github.com/apache/apisix/blob/master/t/config-center-yaml/plugin.t |
|
Hey @monkeyDluffy6017, On a related not after reading https://apenwarr.ca/log/20181113 I'm thinking that we should add |
|
hi @boekkooi-lengoo, try to follow the following test cases: |
|
ping @boekkooi-lengoo |
boekkooi-lengoo
force-pushed
the
avoid-unnecessary-reloads
branch
from
f8e1377
to
a04cf84
Compare
Show how a reload is triggered when it's not needed.
In order to avoid unnecessary reloading of the yaml configuration. The time used to detect the last change to the config file is changed from `change` which is the time of the last file status change to the `modification` time wich is the time of the last data modification. For more information also checkou http://lunarmodules.github.io/luafilesystem/manual.html#reference and https://linux.die.net/man/2/stat Fixes: apache#9051
boekkooi-lengoo
force-pushed
the
avoid-unnecessary-reloads
branch
from
a04cf84
to
c3c014b
Compare
|
please merge the master |
|
@monkeyDluffy6017 Created merge commit 684c78d as requested |
monkeyDluffy6017
approved these changes
Jan 12, 2024
AlinsRan
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to avoid unnecessary reloading of the yaml configuration. The time used to detect the last change to the config file is changed from
changewhich is the time of the last file status change to themodificationtime wich is the time of the last data modification.For more information also checkout http://lunarmodules.github.io/luafilesystem/manual.html#reference and https://linux.die.net/man/2/stat
Fixes: #9051
Checklist