Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dubbo protocols support for xrpc #9660

Merged
merged 35 commits into from
Sep 13, 2023
Merged

feat: add dubbo protocols support for xrpc #9660

merged 35 commits into from
Sep 13, 2023

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Jun 14, 2023

Description

Add dubbo protocol extension to apisix

Fixes #8352

@wxbty wxbty changed the title feature: add dubbo protocols support for xrpc feat: add dubbo protocols support for xrpc Jun 14, 2023
@monkeyDluffy6017
Copy link
Contributor

@nic-chen please help to check this

@nic-chen
Copy link
Member

hi @wxbty

Thank you for your PR.

Please add tests for the newly added features first, let's make sure the code works. Thanks !

@wxbty
Copy link
Member Author

wxbty commented Jul 5, 2023

@nic-chen added

nic-chen
nic-chen reviewed Jul 9, 2023
View reviewed changes
apisix/stream/xrpc/protocols/dubbo/init.lua Show resolved Hide resolved
apisix/stream/xrpc/protocols/dubbo/init.lua Outdated Show resolved Hide resolved
apisix/stream/xrpc/protocols/dubbo/init.lua Outdated Show resolved Hide resolved
apisix/stream/xrpc/protocols/dubbo/init.lua Outdated Show resolved Hide resolved
t/xrpc/dubbo.t Show resolved Hide resolved
t/xrpc/dubbo.t Outdated Show resolved Hide resolved
@nic-chen
Copy link
Member

hi @wxbty CI failed, please have a look

@wxbty
Copy link
Member Author

wxbty commented Jul 14, 2023

ok, deal with it later

@wxbty
Copy link
Member Author

wxbty commented Jul 14, 2023

hi @wxbty CI failed, please have a look
Thanks for your review, have added several testcases, but how to trigger ci again?

@Yilialinn
Copy link
Contributor

Hello, @wxbty
On behalf of the APISIX community, I‘d like to invite you to write an article introducing the background and design thinking behind this PR. May I have your contact information for further discussion? Thanks in advance!

@wxbty
Copy link
Member Author

wxbty commented Jul 17, 2023

Happy to discuss with you, wechat: wxb_101

@wxbty wxbty requested a review from nic-chen July 17, 2023 02:48
@Sn0rt Sn0rt mentioned this pull request Jul 18, 2023
Closed
monkeyDluffy6017
monkeyDluffy6017 reviewed Aug 7, 2023
View reviewed changes
t/xrpc/dubbo.t Outdated Show resolved Hide resolved
@monkeyDluffy6017
Copy link
Contributor

Could you merge the master branch?

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Aug 7, 2023
AlinsRan
AlinsRan requested changes Aug 8, 2023
View reviewed changes
.github/workflows/build.yml Outdated
@@ -137,7 +137,7 @@ jobs:
[[ ${{ steps.test_env.outputs.type }} != first ]] && sudo ./ci/init-${{ steps.test_env.outputs.type }}-test-service.sh after
echo "Linux launch services, done."
- name: Start Dubbo Backend
if: matrix.os_name == 'linux_openresty' && steps.test_env.outputs.type == 'plugin'
if: matrix.os_name == 'linux_openresty' && [steps.test_env.outputs.type == 'plugin' || steps.test_env.outputs.type == 'xrpc']
Copy link
Contributor

@AlinsRan AlinsRan Aug 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/apisix/actions/runs/5751049180
Incorrect expression caused the CI to be skipped, please fix it.

@wxbty
Copy link
Member Author

wxbty commented Aug 8, 2023

Could you merge the master branch?

ok

monkeyDluffy6017
monkeyDluffy6017 reviewed Aug 8, 2023
View reviewed changes
t/xrpc/dubbo.t Outdated Show resolved Hide resolved
@wxbty
Copy link
Member Author

wxbty commented Sep 5, 2023

@monkeyDluffy6017 PTAL

@monkeyDluffy6017
Copy link
Contributor

@wxbty ok, i will check this later

@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR user responded labels Sep 13, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 3578fbe into apache:master Sep 13, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sn0rt Sn0rt Sn0rt left review comments

@AlinsRan AlinsRan AlinsRan approved these changes

@nic-chen nic-chen nic-chen approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@kingluo kingluo Awaiting requested review from kingluo

@leslie-tsang leslie-tsang Awaiting requested review from leslie-tsang

Assignees
No one assigned
Labels
approved
Projects
Apache APISIX backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directly support dubbo protocol proxy forwarding
6 participants
@wxbty @monkeyDluffy6017 @nic-chen @Yilialinn @Sn0rt @AlinsRan