Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support pulling env vars from yaml keys #9855

Merged
merged 11 commits into from
Aug 4, 2023
Merged

feat: support pulling env vars from yaml keys #9855

merged 11 commits into from
Aug 4, 2023

Conversation

shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Jul 17, 2023 •
edited
Loading

Description

Fixes #9839

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek shreemaan-abhishek mentioned this pull request Jul 17, 2023
Closed
dreek1337
dreek1337 reviewed Jul 17, 2023
View reviewed changes
Copy link

@dreek1337 dreek1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a more efficient solution!

dreek1337
dreek1337 approved these changes Jul 18, 2023
View reviewed changes
Copy link

@dreek1337 dreek1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great solution, I think it will make it easier for people to work in standalone mode

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jul 24, 2023
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels Aug 2, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit d80fc3b into apache:master Aug 4, 2023
35 checks passed
rubikplanet pushed a commit to rubikplanet/apisix that referenced this pull request Aug 8, 2023
@shreemaan-abhishek @rubikplanet
feat: support pulling env vars from yaml keys (apache#9855)
43c97ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreek1337 dreek1337 dreek1337 approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Changing the apisix.yaml configuration for Standalone mode
4 participants
@shreemaan-abhishek @monkeyDluffy6017 @leslie-tsang @dreek1337