feat(csharp/src/Drivers/Apache/Spark): add request_timeout_ms option to allow longer HTTP request length #2218
Conversation
birschick-bq
requested review from
lidavidm and
CurtHagenlocher
as code owners
|
Need to add unit tests for the range of values. |
| @@ -75,6 +75,8 @@ internal async Task OpenAsync() | |||
|
|
|||
| protected internal HiveServer2TlsOption TlsOptions { get; set; } = HiveServer2TlsOption.Empty; | |||
|
|
|||
| protected internal int RequestTimeout { get; set; } = 30000; | |||
There was a problem hiding this comment.
Slightly pedantic, but should this specify that it is an HTTP timeout since we may support other ways of connecting?
There was a problem hiding this comment.
Updated properties and options to indicate its use with the HTTP type connection.
| @@ -32,6 +32,7 @@ public static class SparkParameters | |||
| public const string Type = "adbc.spark.type"; | |||
| public const string DataTypeConv = "adbc.spark.data_type_conv"; | |||
| public const string TLSOptions = "adbc.spark.tls_options"; | |||
| public const string RequestTimeoutMilliseconds = "adbc.spark.request_timeout_ms"; | |||
There was a problem hiding this comment.
Inline with the property name, I wonder if the setting name should also specify this is for HTTP?
There was a problem hiding this comment.
Updated properties and options to indicate its use with the HTTP type connection.
| @@ -51,5 +51,8 @@ public class ApacheTestConfiguration : TestConfiguration | |||
| [JsonPropertyName("polltime_milliseconds"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)] | |||
| public string PollTimeMilliseconds { get; set; } = string.Empty; | |||
|
|
|||
| [JsonPropertyName("request_timeout_ms"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)] | |||
There was a problem hiding this comment.
Same here -- for the JSON property and C# property name.
There was a problem hiding this comment.
Updated properties and options to indicate its use with the HTTP type connection.
Adds a new connection option to allow longer HTTP request length
adbc.spark.http_request_timeout_mshttp). Set the value higher than the default if you notice errors due to network timeouts.30000