-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inconsistent scalar types in DistinctArrayAggAccumulator
state
#7385
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1271,14 +1271,31 @@ NULL 4 29 1.260869565217 123 -117 23 | |
NULL 5 -194 -13.857142857143 118 -101 14 | ||
NULL NULL 781 7.81 125 -117 100 | ||
|
||
# TODO this querys output is non determinisitic (the order of the elements | ||
# differs run to run | ||
# TODO: array_agg_distinct output is non-determinisitic -- rewrite with array_sort(list_sort) | ||
# unnest is also not available, so manually unnesting via CROSS JOIN | ||
# additional count(1) forces array_agg_distinct instead of array_agg over aggregated by c2 data | ||
# | ||
# csv_query_array_agg_distinct | ||
# query T | ||
# SELECT array_agg(distinct c2) FROM aggregate_test_100 | ||
# ---- | ||
# [4, 2, 3, 5, 1] | ||
query III | ||
WITH indices AS ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can make an input that has at least one non distinct value too -- not just 1,2,3,4,5 but maybe repeat the value
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
SELECT 1 AS idx UNION ALL | ||
SELECT 2 AS idx UNION ALL | ||
SELECT 3 AS idx UNION ALL | ||
SELECT 4 AS idx UNION ALL | ||
SELECT 5 AS idx | ||
) | ||
SELECT data.arr[indices.idx] as element, array_length(data.arr) as array_len, dummy | ||
FROM ( | ||
SELECT array_agg(distinct c2) as arr, count(1) as dummy FROM aggregate_test_100 | ||
) data | ||
CROSS JOIN indices | ||
ORDER BY 1 | ||
---- | ||
1 5 100 | ||
2 5 100 | ||
3 5 100 | ||
4 5 100 | ||
5 5 100 | ||
|
||
# aggregate_time_min_and_max | ||
query TT | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 extend should do the deduplication. 👍