fix: Only validate relevant type_ids for array view slice #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
requested changes
Sep 20, 2024
src/nanoarrow/common/array.c
Outdated
| @@ -1298,6 +1298,15 @@ static int ArrowArrayViewValidateFull(struct ArrowArrayView* array_view, | |||
|
|
|||
| if (array_view->storage_type == NANOARROW_TYPE_DENSE_UNION || | |||
| array_view->storage_type == NANOARROW_TYPE_SPARSE_UNION) { | |||
| struct ArrowBufferView type_ids; | |||
| type_ids.size_bytes = array_view->length * sizeof(int8_t); | |||
src/nanoarrow/common/array.c
Outdated
| @@ -1298,6 +1298,15 @@ static int ArrowArrayViewValidateFull(struct ArrowArrayView* array_view, | |||
|
|
|||
| if (array_view->storage_type == NANOARROW_TYPE_DENSE_UNION || | |||
| array_view->storage_type == NANOARROW_TYPE_SPARSE_UNION) { | |||
| struct ArrowBufferView type_ids; | |||
There was a problem hiding this comment.
To make things clearer/consistenter, should we name this sliced_type_ids or so? (and rename minimal_offsets -> sliced_offsets)?
There was a problem hiding this comment.
Maybe later it'd be helpful to extract ArrowArrayViewSlice which produces an equivalent array view but with offset 0
There was a problem hiding this comment.
The ArrowArrayViewSlice will be useful for a bunch of things...to get consumer functions to work recursively with list types, many of them already accept ArrowArrayView*, offset, length.
There was a problem hiding this comment.
Oh, you meant as a function (will also be helpful!)
bkietz
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #626 but for union type_id arrays. This should fix the two remaining failures in the integration tests between the IPC implementations in the Arrow repository and the nanoarrow IPC implementation apache/arrow#43715.