Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clap Deprecations #1867

Closed
tustvold opened this issue Jun 13, 2022 · 1 comment · Fixed by #1954
Closed

Clap Deprecations #1867

tustvold opened this issue Jun 13, 2022 · 1 comment · Fixed by #1954
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Jun 13, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The most recent clap release deprecated some functionality which is causing clippy to fail on master

use of deprecated unit variant clap::ArgAction::StoreValue

https://epage.github.io/blog/2022/02/clap-31-a-step-towards-40/
clap-rs/clap#3822

Describe the solution you'd like

We should fix this
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jun 13, 2022
@tustvold tustvold self-assigned this Jun 13, 2022
@tustvold tustvold added the development-process Related to development process of arrow-rs label Jun 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 13, 2022
@tustvold
Pin clap to 3.1 (apache#1867)
c74391a
@tustvold tustvold mentioned this issue Jun 13, 2022
Merged
@tustvold tustvold removed their assignment Jun 13, 2022
@tustvold
Copy link
Contributor Author

I've run out of time to work on this, but #1868 should get the pipes moving again

tustvold added a commit that referenced this issue Jun 13, 2022
@tustvold
Pin clap to 3.1 (#1867) (#1868)
f191fa6
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 28, 2022
@tustvold
Unpin clap (apache#1867)
e5ebe28
@tustvold tustvold mentioned this issue Jun 28, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 28, 2022
@tustvold
Unpin clap (apache#1867)
46a6d2e
tustvold added a commit that referenced this issue Jun 28, 2022
@tustvold
Unpin clap (#1867) (#1954)
30e65df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin clap (#1867) tustvold/arrow-rs
1 participant
@tustvold