Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split most arrow specific CI checks into their own workflows (reduce common CI time to 21 minutes) #2168

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 25, 2022

Which issue does this PR close?

Re #2149

Rationale for this change

Breaking up the CI for each crate into more finegrained workflows is a prerequisite for triggering in a more finegrained way (e.g. not run arrow tests if only parquet is changed)

More rationale os #2149

What changes are included in this PR?

Break arrow specific CI checks into a new arrow.yml workflow. It is still triggered on all PRs

Are there any user-facing changes?

There will be more Ci jobs, but hopefully they will each run in less time

@alamb alamb marked this pull request as ready for review July 25, 2022 21:38
@alamb alamb marked this pull request as draft July 25, 2022 21:38
@codecov-commenter
Copy link

Codecov Report

Merging #2168 (eefdaf3) into master (ec3530d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2168   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files         237      237           
  Lines       61429    61429           
=======================================
+ Hits        50902    50903    +1     
+ Misses      10527    10526    -1     
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 63.00% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@alamb alamb marked this pull request as ready for review July 26, 2022 10:55
Copy link
Contributor Author

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tall pole is still the "Test" job but now it takes 21 minutes 🥳 🦜 https://github.com/apache/arrow-rs/runs/7510812685?check_suite_focus=true

uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Test default features
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests are moved from the main Rust.yml test omnibus test

- name: Check compilation with simd features
run: |
cargo check -p arrow --features simd
cargo check -p arrow --features simd --all-targets

windows-and-macos:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure what to do with windows and mac which run in the Rust workflow now -- I am thinking perhaps I could change the CI to run just the jobs for each crate individually for mac 🤔

@@ -54,25 +54,6 @@ jobs:
run: |
# run tests on all workspace members with default feature list
cargo test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking this still runs tests for arrow in the main rust flow as well -- I plan to remove this over time

@alamb alamb changed the title Split most arrow specific CI checks into their own workflows Split most arrow specific CI checks into their own workflows (reduce common CI time to 21 minutes) Jul 26, 2022
@alamb alamb merged commit e96ae8a into apache:master Jul 26, 2022
@alamb alamb deleted the alamb/break_up_arrow_and_parquet branch July 26, 2022 19:45
@alamb
Copy link
Contributor Author

alamb commented Jul 26, 2022

We are slowly getting there -- thanks @viirya

@ursabot
Copy link

ursabot commented Jul 26, 2022

Benchmark runs are scheduled for baseline = 0c64054 and contender = e96ae8a. e96ae8a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants