Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update &Option<T> to Option<&T> #3249

Merged
merged 3 commits into from
Dec 1, 2022
Merged

update &Option<T> to Option<&T> #3249

merged 3 commits into from
Dec 1, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Dec 1, 2022 •
edited
Loading

Which issue does this PR close?

Rationale for this change

Option<&T> is more usable than &Option<T> and can be easily converted.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate parquet-derive labels Dec 1, 2022
tustvold
tustvold reviewed Dec 1, 2022
View reviewed changes
parquet/src/file/metadata.rs
@@ -277,8 +277,8 @@ impl RowGroupMetaData {
}

/// Returns reference of page offset index of all column in this row group.
pub fn page_offset_index(&self) -> &Option<Vec<Vec<PageLocation>>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically an API change

@tustvold tustvold added the api-change Changes to the arrow API label Dec 1, 2022
@tustvold tustvold merged commit f133621 into apache:master Dec 1, 2022
@ursabot
Copy link

ursabot commented Dec 1, 2022

Benchmark runs are scheduled for baseline = c5c34fa and contender = f133621. f133621 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jimexist jimexist deleted the update-option-ref branch December 1, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimexist @ursabot @tustvold