Parquet: write column_orders in FileMetaData #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Dec 2, 2023
Comment on lines
+334
to
+337
| // This field is optional, perhaps in cases where no min/max fields are set | ||
| // in any Statistics or ColumnIndex object in the whole file. | ||
| // But for simplicity we always set this field. | ||
| let column_orders = Some(column_orders); |
There was a problem hiding this comment.
For reference, looks like parquet-mr does something similar
Comment on lines
+327
to
+328
| // Currently only supported ColumnOrder is TypeDefinedOrder so we set this | ||
| // for all leaf nodes. |
There was a problem hiding this comment.
In future there may be new supported order, see here: apache/parquet-format#221
tustvold
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5152
Rationale for this change
What changes are included in this PR?
Populate
column_ordersin ParquetFileMetaDatawhen writing files.Are there any user-facing changes?