Avro block decompression #5306
Merged
Avro block decompression #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jan 16, 2024
| pub enum CompressionCodec { | ||
| Null, |
There was a problem hiding this comment.
None of this is public yet, so this isn't a breaking change
tustvold
commented
Jan 16, 2024
| @@ -55,7 +56,7 @@ impl Header { | |||
| /// Returns an iterator over the meta keys in this header | |||
| pub fn metadata(&self) -> impl Iterator<Item = (&[u8], &[u8])> { | |||
| let mut last = 0; | |||
| self.meta_offsets.windows(2).map(move |w| { | |||
| self.meta_offsets.chunks_exact(2).map(move |w| { | |||
There was a problem hiding this comment.
This is a silly bug, that caused it to fail to read kv pairs after the first
tustvold
commented
Jan 16, 2024
| Deflate, | ||
| BZip2, |
There was a problem hiding this comment.
I opted to just support the codecs that overlapped with parquet for now, to avoid any net new libraries to this project
crepererum
approved these changes
Jan 17, 2024
Co-authored-by: Marco Neumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4886
Rationale for this change
Adds support for block decompression for common codecs.
What changes are included in this PR?
Are there any user-facing changes?