Add more debugging info to StructBuilder validate_content #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
add_debug_info
branch
from
21d88ae
to
dddd991
Compare
viirya
force-pushed
the
add_debug_info
branch
from
dddd991
to
cf0d3cc
Compare
tustvold
approved these changes
Feb 1, 2024
|
Thank you @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Somehow when an error happens during
StructBuilder.validate_content, we found that its error message is not enough for us to investigate which field causes the problem. It might be better to add more debugging info there.What changes are included in this PR?
Adding some more debugging info to the panic error.
Are there any user-facing changes?