fix: msrv CI for object_store #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korowa
force-pushed
the
object-store-msrv
branch
from
f635841
to
83994a0
Compare
korowa
changed the title
korowa
force-pushed
the
object-store-msrv
branch
from
83994a0
to
6897382
Compare
alamb
reviewed
Jun 11, 2024
| @@ -119,17 +119,20 @@ jobs: | |||
| run: cargo update -p ahash --precise 0.8.7 | |||
| - name: Check arrow | |||
| working-directory: arrow | |||
| run: cargo msrv verify | |||
| run: cargo msrv --log-target stdout verify | |||
| - name: Downgrade object_store dependencies | ||
| working-directory: object_store | ||
| # Necessary because 1.30.0 updates MSRV to 1.63 | ||
| run: cargo update -p tokio --precise 1.29.1 | ||
| # Necessary because tokio 1.30.0 updates MSRV to 1.63 |
|
Thanks again @korowa 🙏 |
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5864.
Rationale for this change
Fixing MSRV CI for object store
What changes are included in this PR?
urlcrate while CI explicitly (it seems to be the way to handle such cases)Are there any user-facing changes?
No