Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass empty vectors as min/max for all null pages when building ColumnIndex #6316

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Pass empty vectors as min/max for all null pages when building ColumnIndex #6316

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a501e78
pass empty vecs as min/max for all null pages
etseidl Aug 27, 2024
0bdc00d
add test
etseidl Aug 28, 2024
b4fb414
add some comments to test
etseidl Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parquet/src/column/writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,8 +756,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
if null_page && self.column_index_builder.valid() {
self.column_index_builder.append(
null_page,
vec![0; 1],
vec![0; 1],
vec![],
vec![],
self.page_metrics.num_page_nulls as i64,
);
} else if self.column_index_builder.valid() {
Expand Down
Loading