Support cast between Durations + between Durations all numeric types #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
changed the title
Signed-off-by: tison <[email protected]>
|
CI failure seems exist to master also. Likely unrelated to this patch .. |
I believe it is #6448 which was subsequently fixed |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This resolves #6425.
Rationale for this change
Durations are represent by i64. They can be casted from/to each other just like Timestamps.
What changes are included in this PR?
Support cast between Durations. And catch up support cast between Durations and all numeric type.
Are there any user-facing changes?
Not quite. Users would found new reasonable cast supported, nothing works currently changed.