Skip to content

Commit

Permalink
ARROW-2561: [C++] Fix double free in cuda-test under code coverage
Browse files Browse the repository at this point in the history
As far as I can understand, the problem is due to both shared and static linking
with libarrow.  Some static std::string in libarrow.so would be destroyed twice
at shutdown.  Linking entirely statically seems to fix the issue.
  • Loading branch information
pitrou committed May 16, 2018
1 parent 5bb3d85 commit 0b40b80
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/src/arrow/gpu/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ ADD_ARROW_LIB(arrow_gpu
DEPENDENCIES metadata_fbs
SHARED_LINK_FLAGS ""
SHARED_LINK_LIBS ${ARROW_GPU_SHARED_LINK_LIBS}
STATIC_LINK_LIBS ""
STATIC_LINK_LIBS ${ARROW_GPU_SHARED_LINK_LIBS}
)

# CUDA build version
Expand Down Expand Up @@ -72,7 +72,7 @@ install(
DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")

set(ARROW_GPU_TEST_LINK_LIBS
arrow_gpu_shared
arrow_gpu_static
${ARROW_TEST_LINK_LIBS})

if (ARROW_BUILD_TESTS)
Expand Down

0 comments on commit 0b40b80

Please sign in to comment.