Skip to content

Commit

Permalink
Merge require_sequenced_output and implicit_ordering
Browse files Browse the repository at this point in the history
  • Loading branch information
EnricoMi committed Oct 31, 2024
1 parent 0377ef9 commit 2776b34
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions cpp/src/arrow/dataset/scanner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ Result<acero::ExecNode*> MakeScanNode(acero::ExecPlan* plan,
return batch;
});

auto ordering = require_sequenced_output ? Ordering::Implicit() : Ordering::Unordered();
auto ordering = require_sequenced_output || implicit_ordering ? Ordering::Implicit() : Ordering::Unordered();

auto fields = scan_options->dataset_schema->fields();
if (scan_options->add_augmented_fields) {
Expand All @@ -1071,11 +1071,6 @@ Result<acero::ExecNode*> MakeScanNode(acero::ExecPlan* plan,
}
}

Ordering ordering = Ordering::Unordered();
if (implicit_ordering) {
ordering = Ordering::Implicit();
}

return acero::MakeExecNode(
"source", plan, {},
acero::SourceNodeOptions{schema(std::move(fields)), std::move(gen), ordering});
Expand Down

0 comments on commit 2776b34

Please sign in to comment.