Skip to content

Commit

Permalink
Fix redundant move warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
WillAyd committed Apr 9, 2024
1 parent 433ceef commit 93364b9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cpp/src/arrow/util/decimal.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class ARROW_EXPORT Decimal128 : public BasicDecimal128 {
std::pair<Decimal128, Decimal128> result;
auto dstatus = BasicDecimal128::Divide(divisor, &result.first, &result.second);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(result);
return result;
}

/// \brief Convert the Decimal128 value to a base 10 decimal string with the given
Expand Down Expand Up @@ -118,7 +118,7 @@ class ARROW_EXPORT Decimal128 : public BasicDecimal128 {
Decimal128 out;
auto dstatus = BasicDecimal128::Rescale(original_scale, new_scale, &out);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(out);
return out;
}

/// \brief Convert to a signed integer
Expand Down Expand Up @@ -218,7 +218,7 @@ class ARROW_EXPORT Decimal256 : public BasicDecimal256 {
Decimal256 out;
auto dstatus = BasicDecimal256::Rescale(original_scale, new_scale, &out);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(out);
return out;
}

/// Divide this number by right and return the result.
Expand All @@ -235,7 +235,7 @@ class ARROW_EXPORT Decimal256 : public BasicDecimal256 {
std::pair<Decimal256, Decimal256> result;
auto dstatus = BasicDecimal256::Divide(divisor, &result.first, &result.second);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(result);
return result;
}

/// \brief Convert from a big-endian byte representation. The length must be
Expand Down

0 comments on commit 93364b9

Please sign in to comment.