Address review comments

apache · Oct 16, 2023 · a83f199 · a83f199
1 parent 589f904
commit a83f199
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java b/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java
@@ -22,6 +22,7 @@
 import java.util.Set;
 
 import org.apache.arrow.memory.BufferAllocator;
+import org.apache.arrow.util.VisibleForTesting;
 
 /**
  * A manager for association of dictionary IDs to their corresponding {@link Dictionary}.
@@ -57,6 +58,8 @@ public MapDictionaryProvider(Dictionary... dictionaries) {
      * @param other the {@link DictionaryProvider} to copy the ids and fields from
      * @param allocator allocator to create the empty vectors
      */
+    // This is currently called using JPype by the integration tests.
+    @VisibleForTesting
     public void copyStructureFrom(DictionaryProvider other, BufferAllocator allocator) {
       for (Long id : other.getDictionaryIds()) {
         Dictionary otherDict = other.lookup(id);

diff --git a/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java b/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java
@@ -243,6 +243,7 @@ public VectorSchemaRoot read() throws IOException {
    * @param numBatches the number of batches to skip
    * @return the actual number of skipped batches.
    */
+  // This is currently called using JPype by the integration tests.
   public int skip(int numBatches) throws IOException {
     for (int i = 0; i < numBatches; ++i) {
       JsonToken t = parser.nextToken();