Skip to content

Commit

Permalink
Remove skip_on_cpp_older_than
Browse files Browse the repository at this point in the history
  • Loading branch information
amoeba committed Jul 9, 2024
1 parent a6312a8 commit e3c460d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
12 changes: 0 additions & 12 deletions r/tests/testthat/helper-skip.R
Original file line number Diff line number Diff line change
Expand Up @@ -110,18 +110,6 @@ skip_on_r_older_than <- function(r_version) {
}
}

skip_on_cpp_older_than <- function(cpp_version) {
if (force_tests()) {
return()
}

current_version <- arrow_info()$build_info$cpp_version

if (current_version < cpp_version) {
skip(paste("C++ version:", current_version))
}
}

skip_on_python_older_than <- function(python_version) {
if (force_tests()) {
return()
Expand Down
5 changes: 0 additions & 5 deletions r/tests/testthat/test-parquet.R
Original file line number Diff line number Diff line change
Expand Up @@ -550,11 +550,6 @@ test_that("We can use WriteBatch on ParquetFileWriter", {
})

test_that("WriteBatch on ParquetFileWriter errors when called on closed sink", {
# Skip this test if the Arrow C++ version is <15.0.0 because a check for the
# writer being in the closed state wasn't added until 15 which means this will
# segfault on lower versions.
skip_on_cpp_older_than("15.0.0")

sink <- FileOutputStream$create(tempfile())
sch <- schema(a = int32())
props <- ParquetWriterProperties$create(column_names = names(sch))
Expand Down

0 comments on commit e3c460d

Please sign in to comment.