Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Support Float16 #25163

Closed
asfimport opened this issue Jun 5, 2020 · 0 comments · Fixed by #34618
Closed

[C#] Support Float16 #25163

asfimport opened this issue Jun 5, 2020 · 0 comments · Fixed by #34618
Labels
Component: C# Type: enhancement
Milestone
12.0.0

Comments

@asfimport
Copy link
Collaborator

With dotnet/runtime#936, .NET is getting a System.Half type, which is a 16-bit floating point number. Once that type lands in .NET we can implement support for the Float16 type in Arrow.

Reporter: Eric Erhardt / @eerhardt

Note: This issue was originally created as ARROW-9048. Please see the migration documentation for further details.
@github-actions github-actions bot mentioned this issue Mar 17, 2023
Merged
@wjones127 wjones127 mentioned this issue Mar 27, 2023
Open
9 tasks
eerhardt added a commit that referenced this issue Mar 27, 2023
@teo-tsirpanis @eerhardt
GH-25163: [C#] Support half-float arrays. (#34618)
5e7e764 
### Rationale for this change

.NET 5 introduced the [`System.Half`](https://devblogs.microsoft.com/dotnet/introducing-the-half-type/) type, which represents 16-bit floats. This PR adds support for them in Apache Arrow.

### What changes are included in this PR?

I multi-targeted the `Apache.Arrow` project to .NET 6 (because .NET 5 is unsupported) and added a `HalfFloatArray` type with a very similar implementation as the other floating-point array types.

I also updated the README.

### Are these changes tested?

Yes. I also refactored the array tests to reduce duplication among the various numeric types.

### Are there any user-facing changes?

Yes.
* Closes: #25163

Lead-authored-by: Theodore Tsirpanis <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Signed-off-by: Eric Erhardt <[email protected]>
@eerhardt eerhardt added this to the 12.0.0 milestone Mar 27, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@teo-tsirpanis @eerhardt @ArgusLi
apacheGH-25163: [C#] Support half-float arrays. (apache#34618)
c662f09 
### Rationale for this change

.NET 5 introduced the [`System.Half`](https://devblogs.microsoft.com/dotnet/introducing-the-half-type/) type, which represents 16-bit floats. This PR adds support for them in Apache Arrow.

### What changes are included in this PR?

I multi-targeted the `Apache.Arrow` project to .NET 6 (because .NET 5 is unsupported) and added a `HalfFloatArray` type with a very similar implementation as the other floating-point array types.

I also updated the README.

### Are these changes tested?

Yes. I also refactored the array tests to reduce duplication among the various numeric types.

### Are there any user-facing changes?

Yes.
* Closes: apache#25163

Lead-authored-by: Theodore Tsirpanis <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Signed-off-by: Eric Erhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-25163: [C#] Support half-float arrays. teo-tsirpanis/apache-arrow
2 participants
@eerhardt @asfimport