Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Use a flywheel for struct row #30863

Closed
asfimport opened this issue Jan 19, 2022 · 0 comments · Fixed by #44289
Closed

[JS] Use a flywheel for struct row #30863

asfimport opened this issue Jan 19, 2022 · 0 comments · Fixed by #44289

Comments

@asfimport
Copy link
Collaborator

When we access a row from a table or a struct, we create a proxy for the struct. We could improve the performance of these accesses by creating a single instance of the proxy and store it on the vector or the data type and then reuse that instance.

This should improve performance.

See

return vector.bind(index) as T['TValue'];
and
const proto = this._row || (this._row = new StructRow<T>(this));
.

Reporter: Dominik Moritz / @domoritz

Note: This issue was originally created as ARROW-15379. Please see the migration documentation for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants