Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] CSV and JSON benchmarks should present a items/s or bytes/s metric #39666

Closed
Tracked by #39662
pitrou opened this issue Jan 17, 2024 · 0 comments · Fixed by #39764
Closed
Tracked by #39662

[C++] CSV and JSON benchmarks should present a items/s or bytes/s metric #39666

pitrou opened this issue Jan 17, 2024 · 0 comments · Fixed by #39764
Assignees
@pitrou
Labels
Component: Benchmarking Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jan 17, 2024

Describe the enhancement requested

We should scan through these benchmarks and look for those that only a present an iteration time.

Component(s)

Benchmarking, C++
@pitrou pitrou mentioned this issue Jan 17, 2024
Closed
7 tasks
@pitrou pitrou self-assigned this Jan 23, 2024
pitrou added a commit to pitrou/arrow that referenced this issue Jan 23, 2024
@pitrou
apacheGH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/…
d7f290a 
…s or items/s metric
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Merged
pitrou added a commit that referenced this issue Jan 23, 2024
@pitrou
GH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/s or i…
3fe598a 
…tems/s metric (#39764)

### Rationale for this change

Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.

### What changes are included in this PR?

Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: #39666

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 16.0.0 milestone Jan 23, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/…
30989c3 
…s or items/s metric (apache#39764)

### Rationale for this change

Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.

### What changes are included in this PR?

Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: apache#39666

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@pitrou @zanmato1984
apacheGH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/…
e09b5eb 
…s or items/s metric (apache#39764)

### Rationale for this change

Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.

### What changes are included in this PR?

Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: apache#39666

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@pitrou @thisisnic
apacheGH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/…
dd0e7fa 
…s or items/s metric (apache#39764)

### Rationale for this change

Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.

### What changes are included in this PR?

Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: apache#39666

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Benchmarking Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/s or items/s metric pitrou/arrow
1 participant
@pitrou