Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41176

Closed
kou opened this issue Apr 12, 2024 · 1 comment
Closed

[C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41176

kou opened this issue Apr 12, 2024 · 1 comment
Assignees
Milestone

Comments

@kou
Copy link
Member

kou commented Apr 12, 2024

Describe the bug, including details regarding any error messages, version, and platform.

We already have the ARROW_VALGRIND macro for Valgrind. We don't need to define a new macro for Valgrind.

See also: #41163 (comment)

Component(s)

C++

@kou kou added the Type: bug label Apr 12, 2024
@kou kou added this to the 16.0.0 milestone Apr 12, 2024
kou added a commit to kou/arrow that referenced this issue Apr 12, 2024
kou added a commit that referenced this issue Apr 13, 2024
…41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member Author

kou commented Apr 13, 2024

Issue resolved by pull request 41177
#41177

@kou kou closed this as completed Apr 13, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Apr 15, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
raulcd pushed a commit that referenced this issue Apr 15, 2024
…41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant