-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] arrow-vector 16.1.0 has a change that breaks Java 8 support #41717
Comments
ByteBuffer inherits rewind from Buffer and Java 8 has this method. https://docs.oracle.com/javase/8/docs/api/java/nio/Buffer.html#rewind-- I have seem issues in Java 8 where you need to cast to java.nio.Buffer for this to work reliably. In https://issues.apache.org/jira/browse/HADOOP-18197, there were issues where we got on some Java8 installations.
We had to upgrade protobuf-java (which had the ByteBuffer code that was causing us issues) to get this fix: See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/ |
Arrow has this cast in a different part of the code.
Could we add a similar cast in the method that is causing issues? arrow/java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java Line 704 in dcdf4e6
|
fyi: #38051 |
# 🔍 Description A regular dependency upgrading, additionally, Arrow 15 introduced the eclipse-collections dependencies but removed in Arrow 16. apache/arrow#40896 Note: This PR upgrades Arrow to 16.0.0 instead of 16.1.0 due to apache/arrow#41717 ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GHA --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6391 from pan3793/arrow-16. Closes #6391 d8ea702 [Cheng Pan] 16.0.0 8a8bc46 [Cheng Pan] Bump Arrow from 15.0.2 to 16.1.0 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
…erializer (#41718) ### Rationale for this change ### What changes are included in this PR? #41717 describes issue and change ### Are these changes tested? CI build ### Are there any user-facing changes? * GitHub Issue: #41717 Authored-by: PJ Fanning <[email protected]> Signed-off-by: David Li <[email protected]>
Issue resolved by pull request 41718 |
@lidavidm @assignUser This was also reported (@pan3793) |
…ssageSerializer (apache#41718) ### Rationale for this change ### What changes are included in this PR? apache#41717 describes issue and change ### Are these changes tested? CI build ### Are there any user-facing changes? * GitHub Issue: apache#41717 Authored-by: PJ Fanning <[email protected]> Signed-off-by: David Li <[email protected]>
Describe the bug, including details regarding any error messages, version, and platform.
arrow-vector 16.0.0 works fine for us but upgrading to 16.1.0 causes compile issues for us when we build with Java 8.
We found this in the Apache Pekko CI build.
Component(s)
Java
The text was updated successfully, but these errors were encountered: