Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] List all classes from Flight.proto in flight/types.h,cc #43329

Closed
felipecrv opened this issue Jul 19, 2024 · 1 comment
Closed

[C++] List all classes from Flight.proto in flight/types.h,cc #43329

felipecrv opened this issue Jul 19, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Component: FlightRPC Type: enhancement
Milestone
18.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

Preferably on the same order so we can easily compare the files side by side.

Component(s)

C++, FlightRPC
@github-actions github-actions bot mentioned this issue Jul 19, 2024
Merged
felipecrv added a commit that referenced this issue Jul 22, 2024
@felipecrv
GH-43329: [C++] Order classes in flight/types.h according to Flight.p…
3483ac6 
…roto (#43330)

### Rationale for this change

Identify the differences between Flight.proto and the hand-written types.h,.cc files.

### What changes are included in this PR?

 - Re-ordering of the classes

### Are these changes tested?

By existing tests.
* GitHub Issue: #43329

Authored-by: Felipe Oliveira Carvalho <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
@felipecrv felipecrv added this to the 18.0.0 milestone Jul 22, 2024
@felipecrv
Copy link
Contributor Author

Issue resolved by pull request 43330
#43330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Component: FlightRPC Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@felipecrv