Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Error was not handled #43860

Closed
bigsheeper opened this issue Aug 28, 2024 · 1 comment · Fixed by #43861
Closed

[Go] Error was not handled #43860

bigsheeper opened this issue Aug 28, 2024 · 1 comment · Fixed by #43861
Assignees
@bigsheeper
Labels
Component: Go Type: bug
Milestone
18.0.0

Comments

@bigsheeper
Copy link
Contributor

bigsheeper commented Aug 28, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

The error thrown during the ReadRecords process was not handled or returned correctly.

  1. HasNext returns false because of an error, then the for loop broke:
  1. But the error isn't being returned:

Component(s)

Go
@bigsheeper bigsheeper mentioned this issue Aug 28, 2024
Merged
@bigsheeper bigsheeper mentioned this issue Aug 28, 2024
Open
1 task
zeroshade pushed a commit that referenced this issue Aug 28, 2024
@bigsheeper
GH-43860: [Go][Parquet] Handle the error correctly (#43861)
9d40a6a 
### Rationale for this change
Fixes: #43860

### What changes are included in this PR?
Return error correctly

### Are these changes tested?
Yes

### Are there any user-facing changes?
Nope

* GitHub Issue: #43860

Authored-by: bigsheeper <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
@zeroshade zeroshade added this to the 18.0.0 milestone Aug 28, 2024
@zeroshade
Copy link
Member

Issue resolved by pull request 43861
#43861

bigsheeper added a commit to bigsheeper/arrow that referenced this issue Aug 29, 2024
@bigsheeper
apacheGH-43860: [Go][Parquet] Handle the error correctly (apache#43861)
d4ec63d 
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this issue Aug 29, 2024
Merged
czs007 added a commit to milvus-io/arrow that referenced this issue Aug 29, 2024
@czs007
Merge pull request #1 from bigsheeper/2408-handle-err-v12.0.1
e65fdc0 
apacheGH-43860: [Go][Parquet] Handle the error correctly (apache#43861)
kou pushed a commit to apache/arrow-go that referenced this issue Aug 30, 2024
@bigsheeper @kou
GH-43860: [Go][Parquet] Handle the error correctly (#43861)
92938cb 
### Rationale for this change
Fixes: apache/arrow#43860

### What changes are included in this PR?
Return error correctly

### Are these changes tested?
Yes

### Are there any user-facing changes?
Nope

* GitHub Issue: #43860

Authored-by: bigsheeper <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Sep 3, 2024
@bigsheeper @mapleFU
apacheGH-43860: [Go][Parquet] Handle the error correctly (apache#43861)
e0c570d 
### Rationale for this change
Fixes: apache#43860

### What changes are included in this PR?
Return error correctly

### Are these changes tested?
Yes

### Are there any user-facing changes?
Nope

* GitHub Issue: apache#43860

Authored-by: bigsheeper <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@bigsheeper @khwilson
apacheGH-43860: [Go][Parquet] Handle the error correctly (apache#43861)
2fc8423 
### Rationale for this change
Fixes: apache#43860

### What changes are included in this PR?
Return error correctly

### Are these changes tested?
Yes

### Are there any user-facing changes?
Nope

* GitHub Issue: apache#43860

Authored-by: bigsheeper <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigsheeper bigsheeper

Labels
Component: Go Type: bug
Projects
None yet
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

GH-43860: [Go][Parquet] Handle the error correctly bigsheeper/arrow
2 participants
@zeroshade @bigsheeper