ARROW-2561: [C++] Fix double free in cuda-test under code coverage

[pitrou]

As far as I can understand, the problem is due to both shared and static linking with libarrow. Some static std::string in libarrow.so would be destroyed twice at shutdown. Linking entirely statically seems to fix the issue.

[codecov-io]

Codecov Report

Merging #2048 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   87.44%   87.47%   +0.03%     
==========================================
  Files         189      178      -11     
  Lines       29374    28601     -773     
==========================================
- Hits        25685    25018     -667     
+ Misses       3689     3583     -106

Impacted Files	Coverage Δ
rust/src/buffer.rs
rust/src/datatypes.rs
rust/src/error.rs
rust/src/list.rs
rust/src/builder.rs
rust/src/array.rs
rust/src/memory_pool.rs
rust/src/list_builder.rs
rust/src/bitmap.rs
rust/src/memory.rs
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb3d85...7a9d1b5. Read the comment docs.

[xhochy]

This is probably ok but looks weird that the STATIC_LINK_LIBS list …_SHARED_LINK_LIBS. Can you add a comment that this is intended?

[pitrou]

Done.

[pitrou]

Seems like there's an unrelated failure in test_parquet on AppVeyor:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/build/1.0.6470/job/hx95phkouafslhhp#L5889
and also in one of the Travis-CI jobs (this one I will restart):
https://travis-ci.org/apache/arrow/jobs/379652352#L3124

[xhochy]

+1, LGTM