-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2561: [C++] Fix double free in cuda-test under code coverage #2048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 87.44% 87.47% +0.03%
==========================================
Files 189 178 -11
Lines 29374 28601 -773
==========================================
- Hits 25685 25018 -667
+ Misses 3689 3583 -106 Continue to review full report at Codecov.
|
cpp/src/arrow/gpu/CMakeLists.txt
Outdated
@@ -43,7 +43,7 @@ ADD_ARROW_LIB(arrow_gpu | |||
DEPENDENCIES metadata_fbs | |||
SHARED_LINK_FLAGS "" | |||
SHARED_LINK_LIBS ${ARROW_GPU_SHARED_LINK_LIBS} | |||
STATIC_LINK_LIBS "" | |||
STATIC_LINK_LIBS ${ARROW_GPU_SHARED_LINK_LIBS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably ok but looks weird that the STATIC_LINK_LIBS
list …_SHARED_LINK_LIBS
. Can you add a comment that this is intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Seems like there's an unrelated failure in test_parquet on AppVeyor: |
As far as I can understand, the problem is due to both shared and static linking with libarrow. Some static std::string in libarrow.so would be destroyed twice at shutdown. Linking entirely statically seems to fix the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
As far as I can understand, the problem is due to both shared and static linking with libarrow. Some static std::string in libarrow.so would be destroyed twice at shutdown. Linking entirely statically seems to fix the issue.