-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Plasma] Use jemalloc instead of dlmalloc in plasma #2593
Conversation
ExternalProject_Add(jemalloc | ||
URL ${jemalloc_URL} | ||
DOWNLOAD_DIR "${DOWNLOAD_LOCATION}" | ||
CONFIGURE_COMMAND ./autogen.sh "--prefix=${JEMALLOC_PREFIX}" "--with-jemalloc-prefix=je_plasma_" "--with-private-namespace=je_plasma_private_" "--disable-tls" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the same jemalloc version as we do in Arrow C++. Eventhough they should live happily along eachother, we should not add multiple versions of a library to the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: if we're able to remove our vendored jemalloc by making this upgrade that would be great
Is there a plan about how to proceed on this patch? |
Yes, the plan is like this:
cc @anuragkh who suggested this plan |
ed180da
to
85fe336
Compare
@pcmoritz it looks like this is has gotten fairly out of date, do you have plans to pick it up soon, or should we close the PR? |
This is currently blocked on jemalloc/jemalloc#1329 but I wanted to post it here too in case anybody has an idea how to move forward.
(@xhochy You are an expert with jemalloc, let me know if you have any ideas on what the right way to do this is. I'd really like to have one memory mapped file only if at all possible so we can remove the sending of file descriptors.)