-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3481: [Java] Fix java building failure with Maven 3.5.4 #2738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
==========================================
+ Coverage 87.49% 88.55% +1.05%
==========================================
Files 402 434 +32
Lines 61454 53263 -8191
==========================================
- Hits 53768 47165 -6603
+ Misses 7612 6098 -1514
+ Partials 74 0 -74
Continue to review full report at Codecov.
|
@pcmoritz Please take a look. This PR will solve the following problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I saw this once as well
What does this do? I don't know arrow's java build system well enough, is there anybody else who can take a look? @jacques-n @BryanCutler @siddharthteotia |
I'm not sure which update is useful to solve this problem. https://blogs.apache.org/maven/entry/apache-maven-enforcer-plugin-version . |
@pcmoritz It seems that the old version of this plugin has some compatibility issues with the newest maven. |
I see, got it! Seems like a good change then, let's leave this open a bit longer in case anybody wants to chime in and I'll merge tomorrow :) |
+1 Thanks @guoyuhong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
This problem happens in some rare case. When there are arrow lib build by old maven, but now current maven is updated to 3.5.4. This problem could happen and raise a building failure. Author: Yuhong Guo <[email protected]> Closes #2738 from guoyuhong/fixJavaBuild and squashes the following commits: 7466510 <Yuhong Guo> Fix java build with Maven 3.5.4
This problem happens in some rare case.
When there are arrow lib build by old maven, but now current maven is updated to 3.5.4. This problem could happen and raise a building failure.