Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3481: [Java] Fix java building failure with Maven 3.5.4 #2738

Closed
wants to merge 1 commit into from

Conversation

guoyuhong
Copy link
Contributor

This problem happens in some rare case.
When there are arrow lib build by old maven, but now current maven is updated to 3.5.4. This problem could happen and raise a building failure.

@codecov-io
Copy link

Codecov Report

Merging #2738 into master will increase coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
+ Coverage   87.49%   88.55%   +1.05%     
==========================================
  Files         402      434      +32     
  Lines       61454    53263    -8191     
==========================================
- Hits        53768    47165    -6603     
+ Misses       7612     6098    -1514     
+ Partials       74        0      -74
Impacted Files Coverage Δ
cpp/src/arrow/csv/reader.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/csv/reader.cc 0.53% <0%> (-88.3%) ⬇️
cpp/src/arrow/adapters/orc/adapter.cc 0.26% <0%> (-72.73%) ⬇️
cpp/src/plasma/eviction_policy.cc 54.9% <0%> (-45.1%) ⬇️
cpp/src/plasma/events.cc 52.5% <0%> (-35%) ⬇️
cpp/src/arrow/csv/options.h 66.66% <0%> (-33.34%) ⬇️
cpp/src/plasma/thirdparty/dlmalloc.c 25.95% <0%> (-21.46%) ⬇️
cpp/src/plasma/fling.cc 66.15% <0%> (-18.3%) ⬇️
cpp/src/arrow/util/compression_snappy.cc 73.91% <0%> (-17%) ⬇️
cpp/src/arrow/csv/options.cc 85.71% <0%> (-14.29%) ⬇️
... and 554 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ed7c8...7466510. Read the comment docs.

@guoyuhong
Copy link
Contributor Author

@pcmoritz Please take a look. This PR will solve the following problem.
image

Copy link

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I saw this once as well

@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 2, 2019

What does this do? I don't know arrow's java build system well enough, is there anybody else who can take a look? @jacques-n @BryanCutler @siddharthteotia

@guoyuhong
Copy link
Contributor Author

I'm not sure which update is useful to solve this problem. https://blogs.apache.org/maven/entry/apache-maven-enforcer-plugin-version .
However, after I changed the version. This error is gone.

@raulchen
Copy link

raulchen commented Feb 2, 2019

@pcmoritz It seems that the old version of this plugin has some compatibility issues with the newest maven.

@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 2, 2019

I see, got it! Seems like a good change then, let's leave this open a bit longer in case anybody wants to chime in and I'll merge tomorrow :)

@praveenbingo
Copy link
Contributor

+1 Thanks @guoyuhong

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 7f96b6f Feb 4, 2019
xhochy pushed a commit that referenced this pull request Feb 8, 2019
This problem happens in some rare case.
When there are arrow lib build by old maven, but now current maven is updated to 3.5.4. This problem could happen and raise a building failure.

Author: Yuhong Guo <[email protected]>

Closes #2738 from guoyuhong/fixJavaBuild and squashes the following commits:

7466510 <Yuhong Guo> Fix java build with Maven 3.5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants