Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-32240: [C#] Support decompression when reading an IPC stream from ReadOnlyMemory #34108

Merged
merged 1 commit into from
Feb 10, 2023
Merged

GH-32240: [C#] Support decompression when reading an IPC stream from ReadOnlyMemory #34108

merged 1 commit into from
Feb 10, 2023

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Feb 9, 2023 •
edited by github-actions bot
Loading

This is a small follow-up to #33603 to support reading a compressed IPC stream from a ReadOnlyMemory<byte>, as I missed that this has a separate reader implementation.

@adamreeve adamreeve mentioned this pull request Feb 9, 2023
Merged
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

@westonpace westonpace merged commit 1140ad3 into apache:master Feb 10, 2023
@westonpace
Copy link
Member

Thanks!

@ursabot
Copy link

ursabot commented Feb 11, 2023

Benchmark runs are scheduled for baseline = 05c8b22 and contender = 1140ad3. 1140ad3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.34% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1140ad39 ec2-t3-xlarge-us-east-2
[Finished] 1140ad39 test-mac-arm
[Finished] 1140ad39 ursa-i9-9960x
[Finished] 1140ad39 ursa-thinkcentre-m75q
[Finished] 05c8b222 ec2-t3-xlarge-us-east-2
[Failed] 05c8b222 test-mac-arm
[Finished] 05c8b222 ursa-i9-9960x
[Finished] 05c8b222 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this pull request Feb 17, 2023
@adamreeve
apacheGH-32240: [C#] Support decompression when reading an IPC stream…
2fcd64d 
… from ReadOnlyMemory (apache#34108)

This is a small follow-up to apache#33603 to support reading a compressed IPC stream from a `ReadOnlyMemory<byte>`, as I missed that this has a separate reader implementation.
* Closes: apache#32240

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
@adamreeve @fatemehp
apacheGH-32240: [C#] Support decompression when reading an IPC stream…
5fcc8bb 
… from ReadOnlyMemory (apache#34108)

This is a small follow-up to apache#33603 to support reading a compressed IPC stream from a `ReadOnlyMemory<byte>`, as I missed that this has a separate reader implementation.
* Closes: apache#32240

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] Add decompression support for Record Batches
3 participants
@adamreeve @westonpace @ursabot