ARROW-4296: [C++] [Plasma] Update dlmemalign call to prevent plasma store crash with -f flag #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased |
|
Thanks for the patch! Let me have a closer look if I can figure out what is going (maybe we can replace the dlmemalig with a dlmalloc and use the full space and avoid magic constants). |
|
replaced by #3490 |
robertnishihara
pushed a commit
that referenced
this pull request
Jan 29, 2019
This PR is similar to #3434 but also makes sure we only have one well-tested code path to go through. Author: Philipp Moritz <[email protected]> Closes #3490 from pcmoritz/one-mmap-file and squashes the following commits: c447af5 <Philipp Moritz> remove --verbose f885f49 <Philipp Moritz> reduce plasma store size for test 6072e8f <Philipp Moritz> add verbose flag 990700f <Philipp Moritz> use only one mmapped file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-4296
Starting Plasma with use_one_memory_mapped_file (-f flag) causes a crash, most likely due to improper memory alignment. Changing the dlmemalign call during initialization to use slightly smaller memory (by ~8KB) resolves this.