Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37246: [Java] expose VectorAppender class to offer support to append vector values #37247

Merged

Conversation

davisusanibar
Copy link
Contributor

@davisusanibar davisusanibar commented Aug 18, 2023

Rationale for this change

What changes are included in this PR?

  • Expose VectorAppender class to offer support to append vector values

Are these changes tested?

  • By TestVectorAppender

Are there any user-facing changes?

  • No

@github-actions
Copy link

⚠️ GitHub issue #37246 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 18, 2023
@lidavidm
Copy link
Member

I see this in the Windows CI:

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 s - in org.apache.arrow.memory.TestAllocationManagerNetty
[INFO] Running org.apache.arrow.memory.TestBaseAllocator
16:15:08.268 [main] ERROR o.apache.arrow.memory.BaseAllocator - Memory was leaked by query. Memory leaked: (512)
Allocator(ROOT) 0/512/512/8192 (res/actual/peak/limit)

16:15:08.268 [main] ERROR o.apache.arrow.memory.BaseAllocator - Memory was leaked by query. Memory leaked: (512)
Outstanding child allocators : 
  Allocator(createChildDontClose) 0/512/512/8192 (res/actual/peak/limit)
Allocator(ROOT) 0/512/512/8192 (res/actual/peak/limit)

Warning:  Tests run: 36, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.297 s - in org.apache.arrow.memory.TestBaseAllocator
[INFO] Running org.apache.arrow.memory.TestEmptyArrowBuf

@davisusanibar can you file an issue to investigate this?

@lidavidm
Copy link
Member

Hmm, actually, that's not a failure, I suppose it's just debug log output. But somewhere that CI pipeline fails:

Error:  Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project arrow-memory-netty: 
Error:  
Error:  Please refer to D:\a\arrow\arrow\java\memory\memory-netty\target\surefire-reports for the individual test results.
Error:  Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Error:  ExecutionException Error occurred in starting fork, check output in log
Error:  org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException Error occurred in starting fork, check output in log
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkOnceMultiple(ForkStarter.java:397)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:326)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:269)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1334)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1167)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:931)
Error:  	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
Error:  	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:370)
Error:  	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:351)
Error:  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:215)
Error:  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:171)
Error:  	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:163)
Error:  	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
Error:  	at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:210)
Error:  	at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:195)
Error:  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
Error:  	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
Error:  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
Error:  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
Error:  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
Error:  	at java.base/java.lang.Thread.run(Thread.java:829)
Error:  Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: Error occurred in starting fork, check output in log
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:635)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.lambda$runSuitesForkOnceMultiple$3(ForkStarter.java:388)
Error:  	... 4 more
Error:  -> [Help 1]

@lidavidm lidavidm merged commit 61bff28 into apache:main Aug 18, 2023
13 of 15 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Aug 18, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 61bff28.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…o append vector values (apache#37247)

### Rationale for this change

- To close apache#37246 

### What changes are included in this PR?

- Expose VectorAppender class to offer support to append vector values

### Are these changes tested?

- By TestVectorAppender

### Are there any user-facing changes?

- No
* Closes: apache#37246

Authored-by: david dali susanibar arce <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java]: Expose util methods inside VectorAppender class such as append vector values
2 participants