GH-37608: [C++][Gandiva] TO_DATE function supports YYYY-MM and YYYY #37609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fix for case when pattern does not contain day part
|
|
github-actions
bot
added
Component: C++
Component: C++ - Gandiva
awaiting review
kou
changed the title
github-actions
bot
added
awaiting merge
kou
changed the title
kou
changed the title
DenisTarasyuk
added a commit
to dremio/arrow
that referenced
this pull request
Sep 8, 2023
…YYYY (apache#37609) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit a8a604c. There were 8 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
DenisTarasyuk
added a commit
to dremio/arrow
that referenced
this pull request
Sep 11, 2023
…YYYY (apache#37609) (#48) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk
added a commit
to dremio/arrow
that referenced
this pull request
Sep 26, 2023
…YYYY (apache#37609) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk
added a commit
to dremio/arrow
that referenced
this pull request
Oct 11, 2023
…YYYY (apache#37609) (#48) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
pushed a commit
to dremio/arrow
that referenced
this pull request
Oct 29, 2023
…YYYY (apache#37609) (#48) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk
added a commit
to dremio/arrow
that referenced
this pull request
Nov 2, 2023
…YYYY (apache#37609) (#48) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…YYYY (apache#37609) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…YYYY (apache#37609) Added fix for case when pattern does not contain day part ### Rationale for this change TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'. ### What changes are included in this PR? Add a fix for case when tm_mday is zero to set it to 1 ### Are these changes tested? Added tests that cover described cases ### Are there any user-facing changes? No * Closes: apache#37608 Authored-by: DenisTarasyuk <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for case when pattern does not contain day part
Rationale for this change
TO_DATE Gandiva function returns wrong result if used with pattern 'YYYY-MM' or 'YYYY'.
What changes are included in this PR?
Add a fix for case when tm_mday is zero to set it to 1
Are these changes tested?
Added tests that cover described cases
Are there any user-facing changes?
No