GH-37722: [Java][FlightRPC] Deprecate stateful login methods #37833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Java
awaiting committer review
|
@lidavidm Should I follow suit with the same on the Go side? |
zeroshade
approved these changes
Sep 22, 2023
github-actions
bot
added
awaiting merge
|
Yes, anything based on Handshake should not be preferred by new application code (it's probably just a footgun at best) |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 64acef8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
etseidl
pushed a commit
to etseidl/arrow
that referenced
this pull request
Sep 28, 2023
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The existence of these interfaces confuses users and leads them to antipatterns.
What changes are included in this PR?
Deprecate (but not for removal) the old interfaces.
Are these changes tested?
N/A
Are there any user-facing changes?
Yes.
adbc_driver_flightsql.connectto Java Flight Server #37722