-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35243: [C#] Implement MapType #37885
Conversation
Fix concatenation of Structs to work correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits on comments but looks good
@lidavidm - are you able to help at all? |
Thanks for the ping - I'll look at this tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I restarted the integration pipeline so let's make sure things pass there.
Hmm, there appears to be something wrong with the pipeline
|
Ah, weird, it tried to install 2.5.2 instead of 3.0.2. @CurtHagenlocher can you rebase/merge one last time? It appears we recently had to pin Python to keep pythonnet working |
Looks like another infrastructure problem
|
Well, the C# tests pass so I think let's merge this. |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4b795ec. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <[email protected]> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: David Li <[email protected]>
What changes are included in this PR?
This change includes the original work by
@Platob
from #35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.)Are these changes tested?
Yes.
Are there any user-facing changes?
Maps are now supported in the C# implementation.
Closes #35243