GH-37910: [Java][Integration] Implement C Data Interface integration testing #38248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Oct 12, 2023
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java
Show resolved
Hide resolved
github-actions
bot
added
awaiting merge
pitrou
force-pushed
the
java-c-data-integration
branch
from
db393ef
to
94505c6
Compare
pitrou
requested review from
assignUser,
kou,
raulcd and
zeroshade
as code owners
pitrou
commented
Oct 16, 2023
|
I'm gonna wait for #38314 to be merged and will then rebase this PR. |
pitrou
force-pushed
the
java-c-data-integration
branch
from
54cee6c
to
1b9f547
Compare
pitrou
commented
Oct 19, 2023
Comment on lines
+227
to
+228
| # Note: no need to call the Go GC anywhere thanks to Arrow Go's | ||
| # explicit refcounting. |
There was a problem hiding this comment.
@zeroshade Your changes did the trick!
|
I'm going to merge now. |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ea936e3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…ation testing (apache#38248) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#37910 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…ation testing (apache#38248) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#37910 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ation testing (apache#38248) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#37910 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?