Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38879: [C++][Gandiva] Fix Gandiva to_date function's validation for supress errors parameter #38987

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

niyue
Copy link
Contributor

@niyue niyue commented Nov 29, 2023

Rationale for this change

  • This PR fixes the to_date_utf8_utf8_int32 gandiva function to avoid crash for invalid input

What changes are included in this PR?

  • A bug fix for to_date_utf8_utf8_int32 parameter validation

Are these changes tested?

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

Are there any user-facing changes?

No

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit d66780d into apache:main Nov 29, 2023
29 of 32 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 29, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 29, 2023
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d66780d.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this pull request May 14, 2024
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this pull request May 14, 2024
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this pull request May 14, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this pull request May 15, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this pull request May 15, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this pull request May 16, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this pull request May 21, 2024
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this pull request May 22, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this pull request May 22, 2024
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants