-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38879: [C++][Gandiva] Fix Gandiva to_date function's validation for supress errors parameter #38987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d66780d. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ion for supress errors parameter (apache#38987) ### Rationale for this change * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input ### What changes are included in this PR? * A bug fix for to_date_utf8_utf8_int32 parameter validation ### Are these changes tested? Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function ### Are there any user-facing changes? No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) ### Rationale for this change * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input ### What changes are included in this PR? * A bug fix for to_date_utf8_utf8_int32 parameter validation ### Are these changes tested? Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function ### Are there any user-facing changes? No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) ### Rationale for this change * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input ### What changes are included in this PR? * A bug fix for to_date_utf8_utf8_int32 parameter validation ### Are these changes tested? Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function ### Are there any user-facing changes? No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) ### Rationale for this change * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input ### What changes are included in this PR? * A bug fix for to_date_utf8_utf8_int32 parameter validation ### Are these changes tested? Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function ### Are there any user-facing changes? No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
to_date_utf8_utf8_int32
gandiva function to avoid crash for invalid inputWhat changes are included in this PR?
Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function
Are there any user-facing changes?
No